-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add lightclient
module and migrate block header state in this module
#1976
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1976 +/- ##
===========================================
+ Coverage 70.01% 71.11% +1.09%
===========================================
Files 235 245 +10
Lines 13477 13643 +166
===========================================
+ Hits 9436 9702 +266
+ Misses 3589 3495 -94
+ Partials 452 446 -6
|
Will wait on #1961 to be merged as it will have some conflicts with the tests |
!!!WARNING!!! Be very careful about using Only suppress a single rule (or a specific set of rules) within a section of code, while continuing to scan for other problems. To do this, you can list the rule(s) to be suppressed within the #nosec annotation, e.g: /* #nosec G401 */ or //#nosec G201 G202 G203 Pay extra attention to the way |
Description
lightclient
module to offload the block header data currently inobserver
thereBlockHeaderState
intoChainState
to avoid confusion with "having the state of a block header" since this represents the overall state for block headers for a specific chainscrosschainFlags
toverificationFlags
part of thelightclient
module stateAddBlockHeader
inVoteBlockHeader
forobserver
lightclient
moduleVerificationFlags
NOTE: I didn't include a migration script. Currently the block headers features is disabled on live networks. Introducing this module will simply set the state at 0. Including a migration script would introduce risks without benefits as there is no block headers for mainnet
Closes: #1491 #1975